Strichliste/strichliste
Watch
3
0
Fork
You've already forked strichliste
 0
Code Issues 42 Pull requests 2 Projects Releases 1 Packages Wiki Activity Actions

fix(account_limit): Moves the account limit checking logic into Transaction::create #40

Merged
Ghost merged 4 commits from fix/account_limit into main 2025-09-12 22:19:28 +02:00
Conversation 22 Commits 4 Files changed 8 +238 -245
Ghost commented 2025-09-09 16:49:04 +02:00 (Migrated from code.ole.blue)
Copy link

closes #39

closes #39
Ghost commented 2025-09-09 16:59:58 +02:00 (Migrated from code.ole.blue)
Copy link

also closes #22

also closes #22
Ghost (Migrated from code.ole.blue) reviewed 2025-09-09 23:22:19 +02:00
Ghost (Migrated from code.ole.blue) left a comment
Copy link
No description provided.
can we extract out the functionality of mapping a total delta money to a delta money per user into an own function and use it here as well as in the actual position where the database gets updatd?
Ghost commented 2025-09-09 23:25:42 +02:00 (Migrated from code.ole.blue)
Copy link

Yes, but for what goal?

Yes, but for what goal?
Ghost commented 2025-09-09 23:30:36 +02:00 (Migrated from code.ole.blue)
Copy link

catching the last case and having a way shorter function in general

catching the last case and having a way shorter function in general
Ghost commented 2025-09-10 01:03:52 +02:00 (Migrated from code.ole.blue)
Copy link

What do you mean with catching the last case? This?

use it here as well as in the actual position where the database gets updatd?

I don't quite understand what you mean by that.

What do you mean with catching the last case? This? > use it here as well as in the actual position where the database gets updatd? I don't quite understand what you mean by that.
Ghost (Migrated from code.ole.blue) reviewed 2025-09-10 12:09:13 +02:00
Ghost (Migrated from code.ole.blue) reviewed 2025-09-10 12:38:56 +02:00
Ghost (Migrated from code.ole.blue) reviewed 2025-09-10 12:41:23 +02:00
Ghost (Migrated from code.ole.blue) reviewed 2025-09-10 13:15:44 +02:00
Ghost commented 2025-09-10 13:36:37 +02:00 (Migrated from code.ole.blue)
Copy link

rebased locally

rebased locally
Ghost (Migrated from code.ole.blue) reviewed 2025-09-10 15:41:30 +02:00
Ghost (Migrated from code.ole.blue) reviewed 2025-09-10 16:01:37 +02:00
Ghost (Migrated from code.ole.blue) reviewed 2025-09-11 02:29:23 +02:00
Ghost (Migrated from code.ole.blue) reviewed 2025-09-11 02:31:42 +02:00
Ghost (Migrated from code.ole.blue) reviewed 2025-09-11 10:18:12 +02:00
Ghost (Migrated from code.ole.blue) left a comment
Copy link
No description provided.
Am I missing something or is the split money function an other things still missing? Am confused. If so just mark the pr as draft :)
Ghost commented 2025-09-11 11:17:26 +02:00 (Migrated from code.ole.blue)
Copy link

Am I missing something or is the split money function an other things still missing? Am confused.

If so just mark the pr as draft :)

It's there, git just made the diff wierd

> Am I missing something or is the split money function an other things still missing? Am confused. > > If so just mark the pr as draft :) It's there, git just made the diff wierd
Ghost (Migrated from code.ole.blue) reviewed 2025-09-11 11:18:12 +02:00
Ghost (Migrated from code.ole.blue) reviewed 2025-09-11 16:13:31 +02:00
Ghost (Migrated from code.ole.blue) left a comment
Copy link
No description provided.
2 nitpicks, otherwise looks great
Ghost commented 2025-09-11 16:14:06 +02:00 (Migrated from code.ole.blue)
Copy link

Am I missing something or is the split money function an other things still missing? Am confused.
If so just mark the pr as draft :)

It's there, git just made the diff wierd

Github not showing diff because its large 🤡

> > Am I missing something or is the split money function an other things still missing? Am confused. > > If so just mark the pr as draft :) > > It's there, git just made the diff wierd Github not showing diff because its large :clown_face:
Ghost (Migrated from code.ole.blue) reviewed 2025-09-12 19:48:46 +02:00
Ghost (Migrated from code.ole.blue) approved these changes 2025-09-12 22:18:59 +02:00
Ghost commented 2025-09-12 22:20:08 +02:00 (Migrated from code.ole.blue)
Copy link

Closes #55

Closes #55
Sign in to join this conversation.
Reviewers
No reviewers
Ghost
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
Feature Request

   
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
improvement

   
in progress

   
invalid
This doesn't seem right

  
nag

   
Priority: High

   
Priority: Low

   
Priority: Medium

   
question
Further information is requested

  
refactor

   
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
Feature Request
good first issue
help wanted
improvement
in progress
invalid
nag
Priority: High
Priority: Low
Priority: Medium
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Strichliste/strichliste!40
No description provided.